Bug 210594 - Validate socket in NetworkRTCProvider::wrapNewTCPConnection
Summary: Validate socket in NetworkRTCProvider::wrapNewTCPConnection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-16 01:02 PDT by youenn fablet
Modified: 2020-04-17 10:18 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.95 KB, patch)
2020-04-16 01:04 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (2.07 KB, patch)
2020-04-17 05:38 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-04-16 01:02:34 PDT 
Validate socket in NetworkRTCProvider::wrapNewTCPConnection
Comment 1 youenn fablet 2020-04-16 01:03:03 PDT 
rdar://problem/61783652
Comment 2 youenn fablet 2020-04-16 01:04:58 PDT 
Created attachment 396627 [details]
Patch
Comment 3 Eric Carlson 2020-04-16 06:59:58 PDT 
Comment on attachment 396627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396627&action=review

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:176
> +        if (auto socket = m_pendingIncomingSockets.take(newConnectionSocketIdentifier))
> +            addSocket(identifier, makeUnique<LibWebRTCSocketClient>(identifier, *this, WTFMove(socket), Socket::Type::ServerConnectionTCP));

Would logging when the socket is NULL be helpful?
Comment 4 youenn fablet 2020-04-17 05:38:45 PDT 
Created attachment 396757 [details]
Patch for landing
Comment 5 EWS 2020-04-17 10:18:04 PDT 
Committed r260260: <https://trac.webkit.org/changeset/260260>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396757 [details].