Bug 210531 - Data Detected Actions sheets are presented from odd locations.
Summary: Data Detected Actions sheets are presented from odd locations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-14 21:50 PDT by Megan Gardner
Modified: 2020-04-15 13:21 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.30 KB, patch)
2020-04-14 21:51 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (4.77 KB, patch)
2020-04-15 09:47 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (4.76 KB, patch)
2020-04-15 11:19 PDT, Megan Gardner 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-04-14 21:50:17 PDT 
Data Detected Actions sheets are presented from odd locations.
Comment 1 Megan Gardner 2020-04-14 21:51:44 PDT 
Created attachment 396498 [details]
Patch
Comment 2 Tim Horton 2020-04-14 21:56:33 PDT 
Comment on attachment 396498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:757
> +    if ([delegate respondsToSelector:@selector(_createTargetedContextMenuHintPreviewIfPossible)])
> +        return [delegate _createTargetedContextMenuHintPreviewIfPossible];

Is this not important for other clients of WKActionSheetAssistant (whoever they are? WKPDFView?)
Comment 3 Wenson Hsieh 2020-04-14 21:57:30 PDT 
Comment on attachment 396498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:66
> +- (UITargetedPreview *)_createTargetedContextMenuHintPreviewIfPossible;

Nit - delegate methods usually take the object that’s calling into the delegate as an argument.
Comment 4 Tim Horton 2020-04-14 21:57:45 PDT 
Comment on attachment 396498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:66
> +- (UITargetedPreview *)_createTargetedContextMenuHintPreviewIfPossible;

where's the parameter indicating which action sheet assistant the delegate should respond for?
Comment 5 Megan Gardner 2020-04-15 09:47:41 PDT 
Created attachment 396543 [details]
Patch
Comment 6 Wenson Hsieh 2020-04-15 10:12:06 PDT 
Comment on attachment 396543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396543&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:757
> +    if ([delegate respondsToSelector:@selector(createTargetedContextMenuHintForAcitionSheetAssistant:)])
> +        return [delegate createTargetedContextMenuHintForAcitionSheetAssistant:self];

Nit - “Acition"
Comment 7 Megan Gardner 2020-04-15 11:19:45 PDT 
Created attachment 396552 [details]
Patch for landing
Comment 8 EWS 2020-04-15 12:57:15 PDT 
Found 4 new test failures: imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html, imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/target.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles.html
Comment 9 Megan Gardner 2020-04-15 13:20:32 PDT 
Committed r260146: <https://trac.webkit.org/changeset/260146>
Comment 10 Radar WebKit Bug Importer 2020-04-15 13:21:20 PDT 
<rdar://problem/61844617>