Bug 210523 - File Upload Menus presented from odd locations.
Summary: File Upload Menus presented from odd locations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-14 16:43 PDT by Megan Gardner
Modified: 2020-04-14 21:13 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.99 KB, patch)
2020-04-14 16:45 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (3.81 KB, patch)
2020-04-14 17:31 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-04-14 16:43:07 PDT 
File Upload Menus presented from odd locations.
Comment 1 Megan Gardner 2020-04-14 16:45:07 PDT 
Created attachment 396476 [details]
Patch
Comment 2 Megan Gardner 2020-04-14 16:46:08 PDT 
<rdar://problem/60390846>
Comment 3 Wenson Hsieh 2020-04-14 16:53:47 PDT 
Approach seems reasonable to me, but please test that presenting a context menu and then immediately tapping on a file picker (and vice versa) doesn’t break. We’ve had recent bugs where reusing preview containers for context menu/drag and drop have caused animation glitches.
Comment 4 Megan Gardner 2020-04-14 17:31:35 PDT 
Created attachment 396482 [details]
Patch
Comment 5 EWS 2020-04-14 21:13:51 PDT 
Committed r260116: <https://trac.webkit.org/changeset/260116>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396482 [details].