Bug 210504 - Add bundle SPI to call WebPage::setTopContentInset
Summary: Add bundle SPI to call WebPage::setTopContentInset
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-14 11:20 PDT by Alex Christensen
Modified: 2020-04-14 13:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.28 KB, patch)
2020-04-14 11:21 PDT, Alex Christensen 		simon.fraser: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-04-14 11:20:32 PDT 
Add bundle SPI to call WebPage::setTopContentInset
Comment 1 Alex Christensen 2020-04-14 11:21:23 PDT 
Created attachment 396442 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-04-14 11:21:50 PDT 
<rdar://problem/61781406>
Comment 3 Simon Fraser (smfr) 2020-04-14 11:50:14 PDT 
Comment on attachment 396442 [details]
Patch

Please explain how this interacts with WebViewImpl::updateContentInsetsIfAutomatic() - m_automaticallyAdjustsContentInsets is on by default in WKWebView. That's called from WebViewImpl::renewGStateI(), which is called whenever AppKit jiggles the view hierarchy, which is a lot.
Comment 4 Alex Christensen 2020-04-14 13:04:14 PDT 
When this is called we could also send a message to the WebPageProxy to update it.  Would that resolve your concerns?
Comment 5 Tim Horton 2020-04-14 13:07:40 PDT 
What does it /mean/, though? Does automaticallyAdjustsContentInsets become NO, too? It's all very weird.

But definitely the UIProcess needs to know when it changes, yes.