Bug 210470 - REGRESSION (r259587): bterlson/eshost throws during init in strict mode
Summary: REGRESSION (r259587): bterlson/eshost throws during init in strict mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Minor
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-13 18:18 PDT by Alexey Shvayka
Modified: 2020-04-13 20:06 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2020-04-13 18:33 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2020-04-13 18:18:50 PDT 
bterlson/eshost is used by bterlson/test262-harness, which is used by https://test262.report.
As of r259587, JSC fails all tests in strict mode.
During init, bterlson/eshost does `$262.IsHTMLDDA = function() {...}`, which causes TypeError because "IsHTMLDDA" property has no setter.
Comment 1 Alexey Shvayka 2020-04-13 18:33:18 PDT 
Created attachment 396369 [details]
Patch
Comment 2 Ross Kirsling 2020-04-13 18:54:44 PDT 
Comment on attachment 396369 [details]
Patch

Holy cow, good work. I was having a hell of a time trying to track down where this was coming from myself.
Comment 3 EWS 2020-04-13 20:05:27 PDT 
Committed r260057: <https://trac.webkit.org/changeset/260057>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396369 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-13 20:06:14 PDT 
<rdar://problem/61752521>