Bug 210217 - [LLInt] Add fast path for TypedArray access on LLInt 32-bits
Summary: [LLInt] Add fast path for TypedArray access on LLInt 32-bits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-08 15:20 PDT by Caio Lima
Modified: 2020-04-10 05:20 PDT (History)
8 users (show)

See Also:

Attachments
Patch (11.51 KB, patch)
2020-04-08 16:41 PDT, Caio Lima 		no flags Details | Formatted Diff | Diff
Patch (11.50 KB, patch)
2020-04-08 17:50 PDT, Caio Lima 		no flags Details | Formatted Diff | Diff
Patch for landing (11.65 KB, patch)
2020-04-10 03:25 PDT, Caio Lima 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2020-04-08 15:20:39 PDT 
...
Comment 1 Caio Lima 2020-04-08 16:41:29 PDT 
Created attachment 395886 [details]
Patch
Comment 2 Caio Lima 2020-04-08 17:50:19 PDT 
Created attachment 395892 [details]
Patch
Comment 3 Yusuke Suzuki 2020-04-09 17:18:16 PDT 
Comment on attachment 395892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395892&action=review

r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1565
> +    getByValTypedArray(t0, t1, finishIntGetByVal, finishDoubleGetByVal, .opGetByValSlow, cagedPrimitive)

You should define `cagedPrimitive` in 32bit LowLevelInterpreter as empty macro instead of passing it to getByValTypedArray
Comment 4 Caio Lima 2020-04-10 03:25:48 PDT 
Created attachment 396071 [details]
Patch for landing

Thank you very much for the review
Comment 5 EWS 2020-04-10 05:19:46 PDT 
Committed r259866: <https://trac.webkit.org/changeset/259866>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396071 [details].
Comment 6 Radar WebKit Bug Importer 2020-04-10 05:20:14 PDT 
<rdar://problem/61579403>