Bug 210164 - Remove ENABLE_INTL define
Summary: Remove ENABLE_INTL define
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
: 186020 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-04-07 15:33 PDT by Ross Kirsling
Modified: 2020-04-14 18:03 PDT (History)
24 users (show)

See Also:

Attachments
Patch (57.42 KB, patch)
2020-04-07 15:46 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2020-04-07 15:33:49 PDT 
Remove ENABLE_INTL define
Comment 1 Ross Kirsling 2020-04-07 15:46:23 PDT 
Created attachment 395754 [details]
Patch
Comment 2 Konstantin Tokarev 2020-04-07 17:07:53 PDT 
Why? This is important feature for developers of embedded systems, allowing to cut of some stuff from ICU
Comment 3 Ross Kirsling 2020-04-07 17:15:24 PDT 
(In reply to Konstantin Tokarev from comment #2)
> Why? This is important feature for developers of embedded systems, allowing
> to cut of some stuff from ICU

As I wrote in WTF/ChangeLog, AppleWin was the only upstream platform turning it off. We could certainly leave this as an optional feature indefinitely, but it seems a bit problematic if there won't be any bots left to ensure that the build works without it.
Comment 4 Ross Kirsling 2020-04-08 12:51:06 PDT 
Note: AppleWin EWS doesn't run JSC tests but I've confirmed that they pass locally.
Comment 5 Ross Kirsling 2020-04-08 14:17:32 PDT 
As for downstream platforms -- I believe it's possible to stub out the data portion of ICU such that you can build and link, even if the output wouldn't pass our tests.
Comment 6 EWS 2020-04-08 17:06:04 PDT 
Committed r259767: <https://trac.webkit.org/changeset/259767>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395754 [details].
Comment 7 Radar WebKit Bug Importer 2020-04-08 17:07:13 PDT 
<rdar://problem/61486343>
Comment 8 Ross Kirsling 2020-04-14 18:03:38 PDT 
*** Bug 186020 has been marked as a duplicate of this bug. ***