Bug 210039 - ARM64 moveConditionallyDouble() for DoubleNotEqualAndOrdered is wrong.
Summary: ARM64 moveConditionallyDouble() for DoubleNotEqualAndOrdered is wrong.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-05 14:44 PDT by Mark Lam
Modified: 2020-04-05 16:00 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (1.91 KB, patch)
2020-04-05 14:53 PDT, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-04-05 14:44:45 PDT 
For the scenario where the dest register is same as the then case register, there is one case instruction that should be executed based on the overflow flag to test for unordered operands.  Instead, we were testing for the not equal condition.  This bug was caught by testmasm.
Comment 1 Radar WebKit Bug Importer 2020-04-05 14:45:12 PDT 
<rdar://problem/61321778>
Comment 2 Mark Lam 2020-04-05 14:53:10 PDT 
Created attachment 395530 [details]
proposed patch.
Comment 3 Yusuke Suzuki 2020-04-05 15:55:59 PDT 
Comment on attachment 395530 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2020-04-05 16:00:30 PDT 
Thanks for the review.  Landed in r259556: <http://trac.webkit.org/r259556>.