Bug 210007 - Remove LockHistory parameter from loadWithNavigationAction
Summary: Remove LockHistory parameter from loadWithNavigationAction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-04 10:28 PDT by Rob Buis
Modified: 2020-04-04 22:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.31 KB, patch)
2020-04-04 10:30 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-04-04 10:28:28 PDT 
Remove LockHistory parameter from loadWithNavigationAction since NavigationAction
has a member for this. Where needed explicitly set the LockHistory on the actions.
Comment 1 Rob Buis 2020-04-04 10:30:18 PDT 
Created attachment 395456 [details]
Patch
Comment 2 Darin Adler 2020-04-04 16:27:14 PDT 
Comment on attachment 395456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395456&action=review

> Source/WebCore/loader/FrameLoader.cpp:1424
> -    loadWithNavigationAction(request, WTFMove(action), lockHistory, newLoadType, WTFMove(formState), allowNavigationToInvalidURL, frameLoadRequest.downloadAttribute(), [this, isRedirect, sameURL, newLoadType, protectedFrame = makeRef(m_frame), completionHandler = completionHandlerCaller.release()] () mutable {
> +    loadWithNavigationAction(request, WTFMove(action), newLoadType, WTFMove(formState), allowNavigationToInvalidURL, frameLoadRequest.downloadAttribute(), [this, isRedirect, sameURL, newLoadType, protectedFrame = makeRef(m_frame), completionHandler = completionHandlerCaller.release()] () mutable {

How did you determine that it’s not necessary to call setLockHistory on the action here, the way you did in FrameLoader::loadWithNavigationAction?
Comment 3 Darin Adler 2020-04-04 16:27:44 PDT 
Comment on attachment 395456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395456&action=review

>> Source/WebCore/loader/FrameLoader.cpp:1424
>> +    loadWithNavigationAction(request, WTFMove(action), newLoadType, WTFMove(formState), allowNavigationToInvalidURL, frameLoadRequest.downloadAttribute(), [this, isRedirect, sameURL, newLoadType, protectedFrame = makeRef(m_frame), completionHandler = completionHandlerCaller.release()] () mutable {
> 
> How did you determine that it’s not necessary to call setLockHistory on the action here, the way you did in FrameLoader::loadWithNavigationAction?

Oh, I see now. It’s already done above.
Comment 4 EWS 2020-04-04 22:09:48 PDT 
Committed r259544: <https://trac.webkit.org/changeset/259544>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395456 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-04 22:10:15 PDT 
<rdar://problem/61308935>