Bug 209965 - [ews] Improve error message when patch fails to apply to trunk
Summary: [ews] Improve error message when patch fails to apply to trunk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-03 07:25 PDT by Aakash Jain
Modified: 2020-04-03 09:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.89 KB, patch)
2020-04-03 07:30 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-04-03 07:25:57 PDT 
[ews] Improve error message when patch fails to apply to trunk. Current error message is 'Patch does not apply', this might be confusing for few people (especially new contributors).

Better wording would be: 'Tools/Scripts/svn-apply failed to apply patch 123456 to trunk'.
Comment 1 Aakash Jain 2020-04-03 07:30:37 PDT 
Created attachment 395374 [details]
Patch
Comment 3 EWS 2020-04-03 09:26:57 PDT 
Committed r259464: <https://trac.webkit.org/changeset/259464>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395374 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-03 09:27:13 PDT 
<rdar://problem/61262348>