Bug 209919 - Don't call -[AVCapture startRunning] when interruption ends
Summary: Don't call -[AVCapture startRunning] when interruption ends
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-02 12:19 PDT by Eric Carlson
Modified: 2020-04-02 17:14 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.02 KB, patch)
2020-04-02 12:44 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (7.67 KB, patch)
2020-04-02 14:52 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2020-04-02 12:19:47 PDT 
Don't call -[AVCapture startRunning] when interruption ends
Comment 1 Eric Carlson 2020-04-02 12:20:19 PDT 
<rdar://problem/61090625>
Comment 2 Eric Carlson 2020-04-02 12:44:52 PDT 
Created attachment 395288 [details]
Patch
Comment 3 youenn fablet 2020-04-02 13:14:41 PDT 
Comment on attachment 395288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395288&action=review

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:623
>      m_interruption = InterruptionReason::None;

Maybe we could switch m_interruption to "boolean m_interrupted"?

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:698
> +    if (!willChange && m_callback->loggerPtr() && m_callback->logger().willLog(m_callback->logChannel(), WTFLogLevel::Always)) {

Why !willChange?
I would think could write it as if (willChange) or maybe if(isChanging).

Should we return early if wilChange is true?
Comment 4 Eric Carlson 2020-04-02 14:52:29 PDT 
Created attachment 395305 [details]
Patch for landing
Comment 5 Eric Carlson 2020-04-02 15:30:45 PDT 
Comment on attachment 395288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395288&action=review

>> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:623
>>      m_interruption = InterruptionReason::None;
> 
> Maybe we could switch m_interruption to "boolean m_interrupted"?

Good idea, fixed.

>> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:698
>> +    if (!willChange && m_callback->loggerPtr() && m_callback->logger().willLog(m_callback->logChannel(), WTFLogLevel::Always)) {
> 
> Why !willChange?
> I would think could write it as if (willChange) or maybe if(isChanging).
> 
> Should we return early if wilChange is true?

Also a good idea, also fixed.
Comment 6 EWS 2020-04-02 17:14:03 PDT 
Committed r259430: <https://trac.webkit.org/changeset/259430>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395305 [details].