Bug 209731 - Delete css-modsel-* tests under css3/ and fast/
Summary: Delete css-modsel-* tests under css3/ and fast/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-30 04:12 PDT by Antti Koivisto
Modified: 2020-03-30 23:03 PDT (History)
3 users (show)

See Also:

Attachments
patch (9.95 MB, patch)
2020-03-30 04:19 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (30.97 MB, patch)
2020-03-30 04:26 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (10.29 MB, patch)
2020-03-30 04:51 PDT, Antti Koivisto 		graouts: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-03-30 04:12:24 PDT 
Updated WPT reftest versions of these old tests exist under imported/w3c/web-platform-tests/css/selectors/old-tests. Remove the obsolete (and sometimes flaky) render tree dump versions.
Comment 1 Antti Koivisto 2020-03-30 04:19:42 PDT 
Created attachment 394901 [details]
patch
Comment 2 Antti Koivisto 2020-03-30 04:26:45 PDT 
Created attachment 394902 [details]
patch
Comment 3 Antti Koivisto 2020-03-30 04:51:48 PDT 
Created attachment 394905 [details]
patch
Comment 4 EWS 2020-03-30 11:58:38 PDT 
commit-queue failed to commit attachment 394905 [details] to WebKit repository.
Comment 5 Aakash Jain 2020-03-30 14:36:27 PDT 
(In reply to EWS from comment #4)
> commit-queue failed to commit attachment 394905 [details] to WebKit repository.
This large patch takes ~1.5 hours to apply to repository. Meanwhile there might be other commits to the repository modifying same ChangeLog. Therefore commit-queue might keep failing to land this. Better to cq+ in off-peak hours, or land it manually.
Comment 6 EWS 2020-03-30 16:06:14 PDT 
commit-queue failed to commit attachment 394905 [details] to WebKit repository.
Comment 7 Antti Koivisto 2020-03-30 23:00:49 PDT 
Committed revision 259281.
Comment 8 Antti Koivisto 2020-03-30 23:02:11 PDT 
https://trac.webkit.org/changeset/259281/webkit
Comment 9 Radar WebKit Bug Importer 2020-03-30 23:03:25 PDT 
<rdar://problem/61091731>