Bug 209714 - ScrollLatchingState should use WeakPtr<Element>
Summary: ScrollLatchingState should use WeakPtr<Element>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-28 20:20 PDT by Simon Fraser (smfr)
Modified: 2020-03-30 20:36 PDT (History)
9 users (show)

See Also:

Attachments
Patch (6.96 KB, patch)
2020-03-28 20:21 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-03-28 20:20:47 PDT 
ScrollLatchingState should use WeakPtr<Element>
Comment 1 Simon Fraser (smfr) 2020-03-28 20:21:33 PDT 
Created attachment 394856 [details]
Patch
Comment 2 Darin Adler 2020-03-29 01:13:02 PDT 
Comment on attachment 394856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394856&action=review

> Source/WebCore/page/scrolling/ScrollLatchingState.h:48
> +    void setWheelEventElement(Element*);

Does this need to accept null? Could it take a references instead of a pointer?

> Source/WebCore/page/scrolling/ScrollLatchingState.h:57
> +    void setPreviousWheelScrolledElement(Element*);

Ditto.

> Source/WebCore/page/scrolling/ScrollLatchingState.h:61
> +

Ditto.
Comment 3 Simon Fraser (smfr) 2020-03-30 20:35:57 PDT 
https://trac.webkit.org/changeset/259278/webkit
Comment 4 Radar WebKit Bug Importer 2020-03-30 20:36:15 PDT 
<rdar://problem/61087846>