Bug 209602 - REGRESSION(r259042): It creates some test failures (Requested by youenn on #webkit).
Summary: REGRESSION(r259042): It creates some test failures (Requested by youenn on #w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords: InRadar
Depends on:
Blocks: 209538
  Show dependency treegraph
 
Reported: 2020-03-26 09:09 PDT by WebKit Commit Bot
Modified: 2020-03-26 10:52 PDT (History)
3 users (show)

See Also:


Attachments
REVERT of r259042 (25.78 MB, patch)
2020-03-26 09:10 PDT, WebKit Commit Bot
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2020-03-26 09:09:02 PDT
https://trac.webkit.org/changeset/259042 broke the build:
It creates some test failures (Requested by youenn on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2020-03-26 09:10:16 PDT
Created attachment 394618 [details]
REVERT of r259042

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 EWS 2020-03-26 09:17:27 PDT
commit-queue failed to commit attachment 394618 [details] to WebKit repository.
Comment 3 Ryan Haddad 2020-03-26 10:26:16 PDT
(In reply to EWS from comment #2)
> commit-queue failed to commit attachment 394618 [details] to WebKit
> repository.
ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
    The following files contain tab characters:
        trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/asm/aes-586.pl
        trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/asm/aes-armv4.pl
        trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/asm/aes-x86_64.pl
    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
Comment 4 Alexey Proskuryakov 2020-03-26 10:51:52 PDT
Landed the rollback in http://trac.webkit.org/r259054
Comment 5 Radar WebKit Bug Importer 2020-03-26 10:52:16 PDT
<rdar://problem/60926366>