Bug 209519 - REGRESSION(r258314): Leak in MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer()
Summary: REGRESSION(r258314): Leak in MediaPlayerPrivateMediaSourceAVFObjC::updateLast...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-24 16:03 PDT by Jer Noble
Modified: 2020-03-24 17:18 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2020-03-24 16:05 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (2.00 KB, patch)
2020-03-24 16:47 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-03-24 16:03:24 PDT 
REGRESSION(r258314): Leak in MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer()
Comment 1 Jer Noble 2020-03-24 16:04:58 PDT 
<rdar://problem/60609824>
Comment 2 Jer Noble 2020-03-24 16:05:50 PDT 
Created attachment 394433 [details]
Patch
Comment 3 Eric Carlson 2020-03-24 16:09:42 PDT 
Comment on attachment 394433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394433&action=review

> Source/WebCore/ChangeLog:8
> +        Obey the "create" rule and adopt the results of -copyPixelBufferForSourceTime:sourceTimeForDisplay:.

Maybe `"copy" rule` would be more appropriate given the method name?
Comment 4 Jer Noble 2020-03-24 16:47:34 PDT 
Created attachment 394440 [details]
Patch for landing
Comment 5 EWS 2020-03-24 17:18:15 PDT 
Committed r258962: <https://trac.webkit.org/changeset/258962>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394440 [details].