Bug 209343 - Fix JSCOnly build without unified sources
Summary: Fix JSCOnly build without unified sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Michaud
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-20 09:22 PDT by Justin Michaud
Modified: 2020-03-20 11:40 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.91 KB, patch)
2020-03-20 09:28 PDT, Justin Michaud 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2020-03-20 09:22:11 PDT 
I managed to get clangd to work for code completion using the following command:

./Tools/Scripts/build-webkit --jsc-only --cmakeargs="-DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DENABLE_UNIFIED_BUILDS=OFF" && compdb -p WebKitBuild/Release/ list > compile_commands.json

This patch fixes the build for non-unified sources, and adds some extra clangd files to .gitignore.
Comment 1 Justin Michaud 2020-03-20 09:28:27 PDT 
Created attachment 394092 [details]
Patch
Comment 2 Keith Miller 2020-03-20 10:22:32 PDT 
Comment on attachment 394092 [details]
Patch

r=me
Comment 3 EWS 2020-03-20 11:39:41 PDT 
Committed r258774: <https://trac.webkit.org/changeset/258774>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394092 [details].
Comment 4 Radar WebKit Bug Importer 2020-03-20 11:40:12 PDT 
<rdar://problem/60696207>