Bug 209321 - [iOS] Articles on NYTimes.com get truncated when switching between MobileSafari and another app
Summary: [iOS] Articles on NYTimes.com get truncated when switching between MobileSafa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-19 17:00 PDT by Chris Dumez
Modified: 2023-06-28 16:11 PDT (History)
5 users (show)

See Also:


Attachments
Patch (17.93 KB, patch)
2020-03-19 17:53 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (18.30 KB, patch)
2020-03-19 18:35 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-03-19 17:00:30 PDT
Articles on NYTimes.com get truncated when switching between MobileSafari and another app (multitasking).
Comment 1 Chris Dumez 2020-03-19 17:00:41 PDT
<rdar://problem/59763843>
Comment 2 Chris Dumez 2020-03-19 17:53:16 PDT
Created attachment 394050 [details]
Patch
Comment 3 Tim Horton 2020-03-19 18:07:46 PDT
Comment on attachment 394050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394050&action=review

> Source/WebCore/page/Page.h:731
> +    bool shouldFireResizeEvents() const { return m_shouldFireResizeEvents; }
> +    void setShouldFireResizeEvents(bool shouldFireResizeEvents) { m_shouldFireResizeEvents = shouldFireResizeEvents; }

I feel like introducing this as just a boolean setter (instead of a counted thing or a token or etc.) is just asking for trouble later when someone else wants to use it. But fine for now.
Comment 4 Chris Dumez 2020-03-19 18:35:06 PDT
Created attachment 394054 [details]
Patch
Comment 5 Simon Fraser (smfr) 2020-03-19 20:19:17 PDT
Comment on attachment 394054 [details]
Patch

Should we quirk this to nytimes? Seems like a hacky change to have in general.
Comment 6 Chris Dumez 2020-03-20 09:29:12 PDT
(In reply to Simon Fraser (smfr) from comment #5)
> Comment on attachment 394054 [details]
> Patch
> 
> Should we quirk this to nytimes? Seems like a hacky change to have in
> general.

Discussed this with Simon, Geoff and Tim offline. We think it is OK to try this as a general approach for now and reconsider if we find breakage. Those resizes in the background for snapshot are probably not something Web developers know about or even want/need to deal with.
Comment 7 EWS 2020-03-20 10:02:18 PDT
Committed r258767: <https://trac.webkit.org/changeset/258767>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394054 [details].