Created attachment 393894 [details]
Patch

Committed r258673: <https://trac.webkit.org/changeset/258673>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 393894 [details].

<rdar://problem/60613926>

Comment on attachment 393894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393894&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:560
> +static inline RetainPtr<WebAccessibilityObjectWrapper> retainWrapper(WebAccessibilityObjectWrapper* wrapper)
> +{
> +    return RetainPtr<WebAccessibilityObjectWrapper>(wrapper);
> +}

I’m surprised we need this. Doesn’t the retainPtr function from RetainPtr.h work?

(In reply to Darin Adler from comment #4)
> Comment on attachment 393894 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393894&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:560
> > +static inline RetainPtr<WebAccessibilityObjectWrapper> retainWrapper(WebAccessibilityObjectWrapper* wrapper)
> > +{
> > +    return RetainPtr<WebAccessibilityObjectWrapper>(wrapper);
> > +}
> 
> I’m surprised we need this. Doesn’t the retainPtr function from RetainPtr.h
> work?

I misread your comment about this in a previous review as that should use a helper function, but didn't realize that retainPtr already existed. Fixed it in:

https://bugs.webkit.org/show_bug.cgi?id=209269

Thanks very much.