Bug 209238 - REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
Summary: REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undef...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-18 09:29 PDT by Ryan Haddad
Modified: 2020-03-18 10:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2020-03-18 09:48 PDT, Philippe Normand 		jbedard: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2020-03-18 09:29:11 PDT 
The changes to test262-runner in https://trac.webkit.org/changeset/258626 have broken the Apple Catalina test262 bots:

Undefined subroutine &Test262::Runner::setConfiguration called at /Volumes/Data/slave/catalina-debug-tests-test262/build/Tools/Scripts/test262/Runner.pm line 632.
Compilation failed in require at ./Tools/Scripts/test262-runner line 65.
BEGIN failed--compilation aborted at ./Tools/Scripts/test262-runner line 65.

https://build.webkit.org/builders/Apple-Catalina-Debug-Test262-Tests/builds/2153
Comment 1 Philippe Normand 2020-03-18 09:41:06 PDT 
Thanks for the report Ryan,

For the time being I can prepare a partial-rollout of the r258626.
Comment 2 Philippe Normand 2020-03-18 09:47:34 PDT 
Actually I may have a patch!
Comment 3 Philippe Normand 2020-03-18 09:48:39 PDT 
Created attachment 393871 [details]
Patch
Comment 4 Ryan Haddad 2020-03-18 09:56:14 PDT 
I manually applied this patch on one of the affected bots and it does indeed resolve the issue.
Comment 5 Philippe Normand 2020-03-18 10:09:51 PDT 
Committed r258644: <https://trac.webkit.org/changeset/258644>
Comment 6 Radar WebKit Bug Importer 2020-03-18 10:10:15 PDT 
<rdar://problem/60588867>