Update usrsctp to 3212d5413a75d4d039e80874dffd2e44f8087ce4
Created attachment 393801 [details] Patch
<rdar://problem/59362671>
Were these two patches reapplied after updating the source? $ grep -l usrsctp Source/ThirdParty/libwebrtc/WebKit/* Source/ThirdParty/libwebrtc/WebKit/0002-Fixing-usrctp-library-compilation-errors.patch Source/ThirdParty/libwebrtc/WebKit/patch-usrsctp.diff
(In reply to David Kilzer (:ddkilzer) from comment #3) > Were these two patches reapplied after updating the source? > > $ grep -l usrsctp Source/ThirdParty/libwebrtc/WebKit/* > Source/ThirdParty/libwebrtc/WebKit/0002-Fixing-usrctp-library-compilation- > errors.patch > Source/ThirdParty/libwebrtc/WebKit/patch-usrsctp.diff Or if the changes already exist in the updated source tree, can they be removed?
(In reply to David Kilzer (:ddkilzer) from comment #4) > (In reply to David Kilzer (:ddkilzer) from comment #3) > > Were these two patches reapplied after updating the source? > > > > $ grep -l usrsctp Source/ThirdParty/libwebrtc/WebKit/* > > Source/ThirdParty/libwebrtc/WebKit/0002-Fixing-usrctp-library-compilation- > > errors.patch > > Source/ThirdParty/libwebrtc/WebKit/patch-usrsctp.diff > > Or if the changes already exist in the updated source tree, can they be > removed? I see part of this was removed: Source/ThirdParty/libwebrtc/WebKit/0002-Fixing-usrctp-library-compilation-errors.patch So maybe you already applied both of these?
The first one was. The second needs double checking. Youenn and I talked and agreed to use a different revision.
Source/ThirdParty/libwebrtc/WebKit/patch-usrsctp.diff isn't applied in the current checkout, and to reduce change I think we should leave it like that. Half of it doesn't apply any more. My quest to find a different revision is going much slower than anticipated. My home internet isn't as fast as my office internet...
(In reply to Alex Christensen from comment #7) > Source/ThirdParty/libwebrtc/WebKit/patch-usrsctp.diff isn't applied in the > current checkout, and to reduce change I think we should leave it like that. > Half of it doesn't apply any more. It was originally added for Bug 186009, and I filed this upstream bug: https://github.com/sctplab/usrsctp/issues/230 However, it sounds like Source/ThirdParty/libwebrtc/WebKit/patch-usrsctp.diff can simply be removed since everything was fixed upstream already, was in commented out code, or was a false positive.
Created attachment 393949 [details] Patch
Committed r258690: <https://trac.webkit.org/changeset/258690> All reviewed patches have been landed. Closing bug and clearing flags on attachment 393949 [details].