Bug 209200 - Web Inspector: the width of `WI.TabBarItem` can change if the detached window is resized
Summary: Web Inspector: the width of `WI.TabBarItem` can change if the detached window...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 208603
Blocks:
  Show dependency tree / graph
 
Reported: 2020-03-17 15:20 PDT by Devin Rousso
Modified: 2020-03-17 21:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.53 KB, patch)
2020-03-17 15:39 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-03-17 15:20:08 PDT 
From my comment <https://webkit.org/b/204627#c56>:
> We shouldn't need to worry about the value stored in `[WI.TabBar.CachedWidthSymbol]` changing anymore (meaning we don't need to reset it), as we no longer hide icons, meaning that the width of every `WI.TabBarItem` should be constant.

This isn't completely accurate, as we don't shrink `WI.TabBarItem` to their minimum width when detached.
Comment 1 Devin Rousso 2020-03-17 15:39:58 PDT 
Created attachment 393797 [details]
Patch
Comment 2 WebKit Commit Bot 2020-03-17 21:30:27 PDT 
Comment on attachment 393797 [details]
Patch

Clearing flags on attachment: 393797

Committed r258623: <https://trac.webkit.org/changeset/258623>
Comment 3 WebKit Commit Bot 2020-03-17 21:30:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-03-17 21:31:15 PDT 
<rdar://problem/60569940>