Bug 209165 - ScriptDisallowedScope should disable isEventAllowedInMainThread and isEventDispatchAllowedInSubtree asserts in WebKit1
Summary: ScriptDisallowedScope should disable isEventAllowedInMainThread and isEventDi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-16 19:16 PDT by Sunny He
Modified: 2020-03-19 16:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2020-03-16 19:25 PDT, Sunny He 		no flags Details | Formatted Diff | Diff
Patch (2.28 KB, patch)
2020-03-18 18:27 PDT, Sunny He 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sunny He 2020-03-16 19:16:44 PDT 
rdar://59575816
Comment 1 Sunny He 2020-03-16 19:25:08 PDT 
Created attachment 393721 [details]
Patch
Comment 2 Alex Christensen 2020-03-17 23:12:51 PDT 
Could you or Ryosuke elaborate on what these problematic design decisions are?

On non-Cocoa platforms, isInWebProcess returns a constant.  That is problematic.  Maybe the time is come for them to implement this.
Comment 3 Ryosuke Niwa 2020-03-18 12:39:29 PDT 
(In reply to Alex Christensen from comment #2)
> Could you or Ryosuke elaborate on what these problematic design decisions
> are?

Sync delegate callbacks.

> On non-Cocoa platforms, isInWebProcess returns a constant.  That is
> problematic.  Maybe the time is come for them to implement this.

Why would it be? Nobody ships WK1 other than macOS, iOS, and Windows ports these days.
Comment 4 Ryosuke Niwa 2020-03-18 12:41:21 PDT 
Hm... looks like GTK+ build is failing for an unrelated reason? Let's re-try them.
Comment 5 Ryosuke Niwa 2020-03-18 17:51:19 PDT 
Comment on attachment 393721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393721&action=review

> Source/WebCore/dom/ScriptDisallowedScope.h:27
> +#include <WebCore/RuntimeApplicationChecks.h>

Oh, wait, this is not the right way to include this header.
Should be: #icnlude "RuntimeApplicationChecks.h"

This is probably why the build failure is happening on GTK+ etc...
Comment 6 Sunny He 2020-03-18 18:27:42 PDT 
Created attachment 393930 [details]
Patch
Comment 7 EWS 2020-03-19 16:48:24 PDT 
Committed r258744: <https://trac.webkit.org/changeset/258744>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 393930 [details].