Bug 209161 - REGRESSION(r258623): Web Inspector: TabBar: one tab sometimes takes all space when detached
Summary: REGRESSION(r258623): Web Inspector: TabBar: one tab sometimes takes all space...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-16 17:23 PDT by Nikita Vasilyev
Modified: 2020-03-20 14:36 PDT (History)
4 users (show)

See Also:

Attachments
[Video] Bug (1.14 MB, video/quicktime)
2020-03-16 17:23 PDT, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2020-03-16 17:23:22 PDT 
Created attachment 393715 [details]
[Video] Bug

Steps:
1. Detach Web Inspector.
2. Resize it to 500-700px wide.

See the attached video.
Comment 1 Radar WebKit Bug Importer 2020-03-16 17:23:33 PDT 
<rdar://problem/60517433>
Comment 2 Devin Rousso 2020-03-16 22:38:13 PDT 
I think this will be fixed by <https://webkit.org/b/208603>.
Comment 3 Maciej Stachowiak 2020-03-17 01:12:38 PDT 
If fixed by that patch let’s dupe.
Comment 4 Devin Rousso 2020-03-17 14:49:06 PDT 
I was unable to reproduce this before r258550 (bug 208603), but I am confident that it definitely shouldn't happen after.

*** This bug has been marked as a duplicate of bug 208603 ***
Comment 5 Nikita Vasilyev 2020-03-19 13:48:52 PDT 
I can still reproduce this on ToT.
Comment 6 Nikita Vasilyev 2020-03-19 22:17:32 PDT 
This was fixed in r258550 and then broken again in r258623 (Bug 209200 - Web Inspector: the width of `WI.TabBarItem` can change if the detached window is resized).
Comment 7 Devin Rousso 2020-03-20 14:36:48 PDT 
# STEPS TO REPRODUCE:
1. inspect any page
2. undock Web Inspector
3. select the last tab in the tab bar
4. slowly make the Web Inspector undocked window horizontally smaller
=> once there is not enough room for all of the enabled tabs in the available space of the tab bar, the tab bar items will `flex-wrap`, which will cause the tab bar items at the end to be incorrectly perceived as very wide as they attempt to grow to fill any available space, which is huge due to `flex-wrap` and the fact that we choose to hide things starting from the right and moving left

This should be resolved by bug 208603 (attachment 394129 [details]).