Bug 209123 - Simplify ChromeClient.createWindow
Summary: Simplify ChromeClient.createWindow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-15 07:17 PDT by Rob Buis
Modified: 2020-03-16 00:21 PDT (History)
6 users (show)

See Also:

Attachments
Patch (18.00 KB, patch)
2020-03-15 07:28 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-03-15 07:17:27 PDT 
Simplify ChromeClient.createWindow by removing the FrameLoadRequest parameter ; it
was only passed for its ResourceRequest member, which can also be obtained
from the NavigationAction parameter.
Comment 1 Rob Buis 2020-03-15 07:28:05 PDT 
Created attachment 393617 [details]
Patch
Comment 2 WebKit Commit Bot 2020-03-16 00:20:33 PDT 
Comment on attachment 393617 [details]
Patch

Clearing flags on attachment: 393617

Committed r258487: <https://trac.webkit.org/changeset/258487>
Comment 3 WebKit Commit Bot 2020-03-16 00:20:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-03-16 00:21:15 PDT 
<rdar://problem/60485129>