Bug 209041 - Report crashed cell in jsCast in debug builds
Summary: Report crashed cell in jsCast in debug builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-12 23:26 PDT by Yusuke Suzuki
Modified: 2020-03-13 11:24 PDT (History)
7 users (show)

See Also:

Attachments
Patch (11.85 KB, patch)
2020-03-12 23:30 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (11.86 KB, patch)
2020-03-12 23:33 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (12.03 KB, patch)
2020-03-12 23:36 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (12.05 KB, patch)
2020-03-12 23:39 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-03-12 23:26:12 PDT 
Log jsCast crash data to collect information
Comment 1 Yusuke Suzuki 2020-03-12 23:30:03 PDT 
Created attachment 393460 [details]
Patch
Comment 2 Yusuke Suzuki 2020-03-12 23:30:06 PDT 
<rdar://problem/59705631>
Comment 3 Yusuke Suzuki 2020-03-12 23:33:49 PDT 
Created attachment 393461 [details]
Patch
Comment 4 Yusuke Suzuki 2020-03-12 23:36:46 PDT 
Created attachment 393462 [details]
Patch
Comment 5 Yusuke Suzuki 2020-03-12 23:39:30 PDT 
Created attachment 393463 [details]
Patch
Comment 6 Mark Lam 2020-03-12 23:57:39 PDT 
Comment on attachment 393463 [details]
Patch

r=me if EWS bots are happy.
Comment 7 Yusuke Suzuki 2020-03-13 00:46:24 PDT 
Comment on attachment 393463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393463&action=review

> Source/JavaScriptCore/runtime/JSCast.h:36
> +#if ASSERT_ENABLED && CPU(X86_64)

I'll change this to `#if (ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)) && CPU(X86_64)` to get reports in ASan bots.
Comment 8 Yusuke Suzuki 2020-03-13 00:53:38 PDT 
Committed r258386: <https://trac.webkit.org/changeset/258386>
Comment 9 Yusuke Suzuki 2020-03-13 00:57:21 PDT 
Committed r258387: <https://trac.webkit.org/changeset/258387>
Comment 10 Saam Barati 2020-03-13 11:20:00 PDT 
Comment on attachment 393463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393463&action=review

>> Source/JavaScriptCore/runtime/JSCast.h:36
>> +#if ASSERT_ENABLED && CPU(X86_64)
> 
> I'll change this to `#if (ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)) && CPU(X86_64)` to get reports in ASan bots.

why just x86?
Comment 11 Yusuke Suzuki 2020-03-13 11:24:24 PDT 
Comment on attachment 393463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393463&action=review

>>> Source/JavaScriptCore/runtime/JSCast.h:36
>>> +#if ASSERT_ENABLED && CPU(X86_64)
>> 
>> I'll change this to `#if (ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)) && CPU(X86_64)` to get reports in ASan bots.
> 
> why just x86?

Currently we are supporting reportZappedCellAndCrash only on X86_64.