Bug 209015 - [ANGLE] Source/ThirdParty/ANGLE/src/libANGLE/Display.h:221:73: warning: implicitly-declared ‘egl::AttributeMap& egl::AttributeMap::operator=(const egl::AttributeMap&)’ is deprecated [-Wdeprecated-copy]
Summary: [ANGLE] Source/ThirdParty/ANGLE/src/libANGLE/Display.h:221:73: warning: impli...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-12 13:20 PDT by Michael Catanzaro
Modified: 2020-03-16 19:17 PDT (History)
15 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2020-03-12 13:47 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-03-12 13:20:50 PDT 
[398/1919] Building CXX object Source/...r/src/libANGLE/FrameCapture_mock.cpp.o
In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/entry_points_utils.h:17,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture.h:16,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture_mock.cpp:10:
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Display.h: In member function ‘void egl::Display::setAttributes(const egl::AttributeMap&)’:
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Display.h:221:73: warning: implicitly-declared ‘egl::AttributeMap& egl::AttributeMap::operator=(const egl::AttributeMap&)’ is deprecated [-Wdeprecated-copy]
  221 |     void setAttributes(const AttributeMap &attribMap) { mAttributeMap = attribMap; }
      |                                                                         ^~~~~~~~~
In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Debug.h:15,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/State.h:18,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Context.h:52,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture.h:14,
                 from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture_mock.cpp:10:
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/AttributeMap.h:24:5: note: because ‘egl::AttributeMap’ has user-provided ‘egl::AttributeMap::AttributeMap(const egl::AttributeMap&)’
   24 |     AttributeMap(const AttributeMap &other);
      |     ^~~~~~~~~~~~
Comment 1 Michael Catanzaro 2020-03-12 13:47:05 PDT 
Created attachment 393410 [details]
Patch
Comment 2 EWS Watchlist 2020-03-12 13:47:54 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 WebKit Commit Bot 2020-03-15 18:41:19 PDT 
Comment on attachment 393410 [details]
Patch

Clearing flags on attachment: 393410

Committed r258483: <https://trac.webkit.org/changeset/258483>
Comment 4 WebKit Commit Bot 2020-03-15 18:41:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-15 18:42:18 PDT 
<rdar://problem/60478335>
Comment 6 Konstantin Tokarev 2020-03-15 19:00:53 PDT 
Comment on attachment 393410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393410&action=review

> Source/ThirdParty/ANGLE/ChangeLog:10
> +        using.

That's fine, but I guess it would be a good idea to CC ANGLE folks
Comment 7 Kenneth Russell 2020-03-16 19:17:57 PDT 
Thanks for the CC. Filed this against the ANGLE project as https://bugs.chromium.org/p/angleproject/issues/detail?id=4486 .