Bug 208951 - Adopt AVSampleBufferVideoOutput
Summary: Adopt AVSampleBufferVideoOutput
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-11 15:55 PDT by Jer Noble
Modified: 2020-03-16 17:30 PDT (History)
11 users (show)

See Also:

Attachments
Patch (9.80 KB, patch)
2020-03-11 15:59 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (9.83 KB, patch)
2020-03-11 16:22 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-03-11 15:55:31 PDT 
Adopt AVSampleBufferVideoOutput
Comment 1 Jer Noble 2020-03-11 15:59:30 PDT 
<rdar://problem/31763425>
Comment 2 Jer Noble 2020-03-11 15:59:59 PDT 
Created attachment 393298 [details]
Patch
Comment 3 Eric Carlson 2020-03-11 16:03:10 PDT 
Comment on attachment 393298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393298&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:772
> +        m_videoOutput = adoptNS([PAL::allocAVSampleBufferVideoOutputInstance() init]);

Nit: it might be worth adding an ASSERT here
Comment 4 Jer Noble 2020-03-11 16:22:34 PDT 
Created attachment 393303 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2020-03-11 21:57:35 PDT 
Comment on attachment 393303 [details]
Patch for landing

Clearing flags on attachment: 393303

Committed r258314: <https://trac.webkit.org/changeset/258314>
Comment 6 WebKit Commit Bot 2020-03-11 21:57:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Alex Christensen 2020-03-16 17:30:57 PDT 
http://trac.webkit.org/r258533