Bug 208873 - Update WTF/WeakLinking.h to work reliably in the face of pointer signing
Summary: Update WTF/WeakLinking.h to work reliably in the face of pointer signing
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-10 11:54 PDT by Sam Weinig
Modified: 2020-06-08 14:51 PDT (History)
12 users (show)

See Also:

Attachments
Patch (6.78 KB, patch)
2020-03-10 12:03 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (7.38 KB, patch)
2020-03-11 14:35 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-03-10 11:54:27 PDT 
Update WTF/WeakLinking.h to work reliably in the face of pointer signing
Comment 1 Sam Weinig 2020-03-10 12:03:35 PDT 
Created attachment 393171 [details]
Patch
Comment 2 mitz 2020-03-10 12:06:23 PDT 
Comment on attachment 393171 [details]
Patch

Nice decrease in code size, too!
Comment 3 mitz 2020-03-11 08:33:16 PDT 
Perhaps not as elegant, but to meet the requirement of working with C++ member functions, which can’t be redeclared, you could take an alternate approach of just employing ptrauth_strip(…, ptrauth_key_function_pointer) in the existing isNullFunctionPointer.
Comment 4 Sam Weinig 2020-03-11 14:35:05 PDT 
Created attachment 393288 [details]
Patch