Bug 208847 - [CMake] Sync feature defines in XCode projects
Summary: [CMake] Sync feature defines in XCode projects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-09 19:34 PDT by Don Olmstead
Modified: 2020-03-09 21:26 PDT (History)
12 users (show)

See Also:

Attachments
Patch (5.93 KB, patch)
2020-03-09 19:36 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (34.09 KB, patch)
2020-03-09 20:01 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (34.09 KB, patch)
2020-03-09 20:02 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (9.30 KB, patch)
2020-03-09 20:02 PDT, Don Olmstead 		annulen: review+
Details | Formatted Diff | Diff
Patch (5.92 KB, patch)
2020-03-09 20:13 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-03-09 19:34:44 PDT 
There are a few things missing from them.
Comment 1 Don Olmstead 2020-03-09 19:36:31 PDT 
Created attachment 393110 [details]
Patch
Comment 2 Konstantin Tokarev 2020-03-09 19:51:33 PDT 
Comment on attachment 393110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393110&action=review

> Source/cmake/WebKitFeatures.cmake:99
> +    WEBKIT_OPTION_DEFINE(ENABLE_APPLE_PAY_SESSION_V9 "Toggle Apple Pay Session V9 support" PRIVATE OFF)

FWIW, it would be better to move options specific to Mac port to OptionsMac.cmake (I assume that ApplePay is not used in AppleWin or any other port, as well as some other options added in this patch)

> Source/cmake/WebKitFeatures.cmake:141
> +    WEBKIT_OPTION_DEFINE(ENABLE_GPU_PROCESS "Toggle GPU Process support" PRIVATE ON)

Shouldn't it be OFF by default?
Comment 3 Don Olmstead 2020-03-09 20:00:57 PDT 
Comment on attachment 393110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393110&action=review

>> Source/cmake/WebKitFeatures.cmake:99
>> +    WEBKIT_OPTION_DEFINE(ENABLE_APPLE_PAY_SESSION_V9 "Toggle Apple Pay Session V9 support" PRIVATE OFF)
> 
> FWIW, it would be better to move options specific to Mac port to OptionsMac.cmake (I assume that ApplePay is not used in AppleWin or any other port, as well as some other options added in this patch)

They aren't but I want to generate the FeatureList.pm and the whole Mac CMake needs a clean up in general so I'd like to sidestep that for the moment.

>> Source/cmake/WebKitFeatures.cmake:141
>> +    WEBKIT_OPTION_DEFINE(ENABLE_GPU_PROCESS "Toggle GPU Process support" PRIVATE ON)
> 
> Shouldn't it be OFF by default?

Copy pasta error. Fixing now.
Comment 4 Don Olmstead 2020-03-09 20:01:19 PDT Comment hidden (obsolete)
Comment 5 Don Olmstead 2020-03-09 20:02:02 PDT Comment hidden (obsolete)
Comment 6 Don Olmstead 2020-03-09 20:02:40 PDT Comment hidden (obsolete)
Comment 7 Don Olmstead 2020-03-09 20:13:21 PDT 
Created attachment 393116 [details]
Patch
Comment 8 WebKit Commit Bot 2020-03-09 21:26:29 PDT 
Comment on attachment 393116 [details]
Patch

Clearing flags on attachment: 393116

Committed r258185: <https://trac.webkit.org/changeset/258185>
Comment 9 WebKit Commit Bot 2020-03-09 21:26:31 PDT 
All reviewed patches have been landed.  Closing bug.