Bug 208785 - Remember completed subranges during incremental PDF loading
Summary: Remember completed subranges during incremental PDF loading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-08 10:06 PDT by Brady Eidson
Modified: 2020-03-08 17:44 PDT (History)
12 users (show)

See Also:

Attachments
Patch (7.64 KB, patch)
2020-03-08 15:44 PDT, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
PFL (7.79 KB, patch)
2020-03-08 16:07 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
PFL (7.79 KB, patch)
2020-03-08 16:24 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2020-03-08 10:06:30 PDT 
Remember completed subranges during incremental PDF loading

We'll often get asked for the same range twice, or for range contained in previously requested ranges.

To make that (orders of magnitude) more efficient, we should remember which ranges in the PDF buffer have previously been requested.
Comment 1 Brady Eidson 2020-03-08 15:44:02 PDT 
Created attachment 392995 [details]
Patch
Comment 2 Brady Eidson 2020-03-08 15:52:09 PDT 
This relies on the patch in https://bugs.webkit.org/show_bug.cgi?id=208790 landing first (hence lots of failures)
Comment 3 Brady Eidson 2020-03-08 16:07:24 PDT 
Created attachment 392996 [details]
PFL
Comment 4 Brady Eidson 2020-03-08 16:24:33 PDT 
Created attachment 392998 [details]
PFL
Comment 5 WebKit Commit Bot 2020-03-08 17:42:53 PDT 
The commit-queue encountered the following flaky tests while processing attachment 392998 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 160571 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-03-08 17:43:33 PDT 
Comment on attachment 392998 [details]
PFL

Clearing flags on attachment: 392998

Committed r258123: <https://trac.webkit.org/changeset/258123>
Comment 7 WebKit Commit Bot 2020-03-08 17:43:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-03-08 17:44:15 PDT 
<rdar://problem/60207010>