Bug 208771 - [CMake][Win] GenerateSettings.rb are invoked twice in WebCoreBindings.vcxproj and WebCoreTestSupportBindings.vcxproj
Summary: [CMake][Win] GenerateSettings.rb are invoked twice in WebCoreBindings.vcxproj...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-07 13:58 PST by Fujii Hironori
Modified: 2020-03-07 15:20 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.13 KB, patch)
2020-03-07 14:04 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-03-07 13:58:33 PST 
[CMake][Win] GenerateSettings.rb are invoked twice in WebCoreBindings.vcxproj and WebCoreTestSupportBindings.vcxproj

CMake Visual Studio generator put a custom command of
GenerateSettings.rb into both WebCoreBindings.vcxproj and
WebCoreTestSupportBindings.vcxproj because both projects are
using the generated files as source files. This causes
unnecessary recompilation.

The fundamental issue of this bug was fixed in CMake side.
https://gitlab.kitware.com/cmake/cmake/issues/16767

However, WebCoreTestSupportBindings needs to have a direct or
indirect dependency to WebCoreBindings for CMake Visual Studio
generator to eliminate duplicated custom commands. Otherwise,
GenerateSettings.rb will be triggered in both projects.

See also:

Bug 198853 – [CMake][Win] CombinedDomains.json is generated twice in JavaScriptCore_CopyPrivateHeaders and JavaScriptCore projects
Bug 181117 – [CMake][Win] Visual Studio invokes make_names.pl twice
Comment 1 Fujii Hironori 2020-03-07 14:04:28 PST 
Created attachment 392897 [details]
Patch
Comment 2 WebKit Commit Bot 2020-03-07 15:20:56 PST 
Comment on attachment 392897 [details]
Patch

Clearing flags on attachment: 392897

Committed r258083: <https://trac.webkit.org/changeset/258083>
Comment 3 WebKit Commit Bot 2020-03-07 15:20:58 PST 
All reviewed patches have been landed.  Closing bug.