Bug 208719 - Web Inspector: Fix missing icons for WI.ThreadTreeElement and selected Heap Snapshots
Summary: Web Inspector: Fix missing icons for WI.ThreadTreeElement and selected Heap S...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Jon Davis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-06 09:34 PST by Jon Davis
Modified: 2020-03-06 17:19 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.60 KB, patch)
2020-03-06 09:50 PST, Jon Davis 		no flags Details | Formatted Diff | Diff
Patch (33.36 KB, patch)
2020-03-06 14:58 PST, Jon Davis 		no flags Details | Formatted Diff | Diff
Selected Heap Snapshot in dark mode (248.79 KB, image/png)
2020-03-06 14:59 PST, Jon Davis 		no flags Details
Selected Heap Snapshot in light mode (231.71 KB, image/png)
2020-03-06 14:59 PST, Jon Davis 		no flags Details
Thread and TypeObject icons in dark mode (183.98 KB, image/png)
2020-03-06 15:00 PST, Jon Davis 		no flags Details
Thread and TypeObject icons in light mode (176.96 KB, image/png)
2020-03-06 15:01 PST, Jon Davis 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2020-03-06 09:34:55 PST 
Add back the missing Thread icon used in WIThreadTreeElement.
Comment 1 Jon Davis 2020-03-06 09:50:39 PST 
Created attachment 392733 [details]
Patch
Comment 2 Devin Rousso 2020-03-06 10:22:45 PST 
Comment on attachment 392733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392733&action=review

r=me

> Source/WebInspectorUI/UserInterface/Images/InstrumentIcons.svg:171
> +    <g id="ThreadInstrument-light" class="light blue"><use href="#circle"/><use href="#threads"/></g>
> +    <g id="ThreadInstrument-dark" class="dark blue"><use href="#circle"/><use href="#threads"/></g>

I wouldn't really consider this an "instrument".  That's a concept specific to timelines.  It's not the worst thing for it to use this as well, but it would be nice to have it as it's own icon as it's really a unique concept.
Comment 3 Jon Davis 2020-03-06 10:57:37 PST 
Maybe incorporate it into the object type icons with the rounded rect style instead?
Comment 4 Jon Davis 2020-03-06 14:58:54 PST 
Created attachment 392776 [details]
Patch
Comment 5 Jon Davis 2020-03-06 14:59:33 PST 
Created attachment 392777 [details]
Selected Heap Snapshot in dark mode
Comment 6 Jon Davis 2020-03-06 14:59:49 PST 
Created attachment 392778 [details]
Selected Heap Snapshot in light mode
Comment 7 Jon Davis 2020-03-06 15:00:59 PST 
Created attachment 392779 [details]
Thread and TypeObject icons in dark mode
Comment 8 Jon Davis 2020-03-06 15:01:34 PST 
Created attachment 392780 [details]
Thread and TypeObject icons in light mode
Comment 9 Devin Rousso 2020-03-06 16:34:51 PST 
Comment on attachment 392776 [details]
Patch

r=me, nice!
Comment 10 WebKit Commit Bot 2020-03-06 17:18:49 PST 
Comment on attachment 392776 [details]
Patch

Clearing flags on attachment: 392776

Committed r258039: <https://trac.webkit.org/changeset/258039>
Comment 11 WebKit Commit Bot 2020-03-06 17:18:50 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2020-03-06 17:19:18 PST 
<rdar://problem/60177324>