Bug 208680 - RemoteImageBufferMessageHandler should not manage the lifetime of remote buffers
Summary: RemoteImageBufferMessageHandler should not manage the lifetime of remote buffers
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-05 17:22 PST by Dean Jackson
Modified: 2020-03-05 17:31 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2020-03-05 17:22:10 PST
RemoteImageBufferMessageHandler is supposed to be a message handler. However it actually manages the lifetime of the remote image buffer, by sending a CreateImageBuffer message in its constructor, and a ReleaseImageBuffer in its destructor. I think these operations should be explicit, and called from the actual class that represents the local version of the remote buffer (which is a subclass of RemoteImageBufferMessageHandler, but is really using that as a protocol, not for inheritance).

The create and release operations should be methods on RemoteImageBufferMessageHandler.
Comment 1 Radar WebKit Bug Importer 2020-03-05 17:22:18 PST
<rdar://problem/60108973>