Bug 208675 - Add logging channel for GPU Process
Summary: Add logging channel for GPU Process
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-05 16:45 PST by Dean Jackson
Modified: 2020-03-06 13:04 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2020-03-05 16:47 PST, Dean Jackson 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2020-03-05 16:45:37 PST 
Add logging channel for GPU Process
Comment 1 Dean Jackson 2020-03-05 16:47:19 PST 
Created attachment 392650 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-03-05 16:50:15 PST 
<rdar://problem/60107563>
Comment 3 Wenson Hsieh 2020-03-05 16:53:34 PST 
Comment on attachment 392650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392650&action=review

> Source/WebCore/platform/Logging.h:65
> +    M(GPUProcess) \

I think we’ve been trying to avoid mentions of GPUProcess and/or “remote rendering” in WebCore. Can you give an example of where this might be used in WebCore?
Comment 4 Dean Jackson 2020-03-06 13:01:54 PST 
Comment on attachment 392650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392650&action=review

>> Source/WebCore/platform/Logging.h:65
>> +    M(GPUProcess) \
> 
> I think we’ve been trying to avoid mentions of GPUProcess and/or “remote rendering” in WebCore. Can you give an example of where this might be used in WebCore?

Yeah, it seems the only use of GPU Process in WebCore is for the internal setting. In my case I wanted to put some logging around where we use RenderingMode::Remote* like things, and ImageBufferBackend. Can you think of a better logging name?
Comment 5 Wenson Hsieh 2020-03-06 13:04:40 PST 
(In reply to Dean Jackson from comment #4)
> Comment on attachment 392650 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392650&action=review
> 
> >> Source/WebCore/platform/Logging.h:65
> >> +    M(GPUProcess) \
> > 
> > I think we’ve been trying to avoid mentions of GPUProcess and/or “remote rendering” in WebCore. Can you give an example of where this might be used in WebCore?
> 
> Yeah, it seems the only use of GPU Process in WebCore is for the internal
> setting. In my case I wanted to put some logging around where we use
> RenderingMode::Remote* like things, and ImageBufferBackend. Can you think of
> a better logging name?

I see. I think the logging should go into the WebKit layer if at all possible; otherwise, I think it’s probably okay for now, but we should follow up with a patch that moves remote image buffer/GPU process logging out of WebCore and into WebKit (by way of ChromeClient, etc.)