NEW208641
webkitpy: Be explicit about SCM binary locations 
https://bugs.webkit.org/show_bug.cgi?id=208641
Summary webkitpy: Be explicit about SCM binary locations
Jonathan Bedard
Reported 2020-03-05 07:53:06 PST
We shouldn't be relying on the user's PATH to include git and svn binaries.
Attachments
Patch (2.67 KB, patch)
2020-03-05 07:54 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.66 KB, patch)
2020-03-05 16:47 PST, Jonathan Bedard 		ap: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-03-05 07:54:29 PST
Created attachment 392568 [details] Patch
Aakash Jain
Comment 2 2020-03-05 08:20:59 PST
What prompted this change, when this code has been working for years?
Aakash Jain
Comment 3 2020-03-05 08:22:56 PST
Comment on attachment 392568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392568&action=review > Tools/Scripts/webkitpy/common/checkout/scm/git.py:59 > + executable_name = '/usr/bin/git' is this location same on all the OSes? > Tools/Scripts/webkitpy/common/checkout/scm/svn.py:79 > + executable_name = '/usr/local/bin/svn' Ditto.
Alexey Proskuryakov
Comment 4 2020-03-05 08:47:59 PST
Comment on attachment 392568 [details] Patch bot612:~ buildbot$ which svn /usr/bin/svn I think that the git stub is always in /usr/bin currently, but I don't know if that will never change.
Jonathan Bedard
Comment 5 2020-03-05 09:52:56 PST
(In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 392568 [details] > Patch > > bot612:~ buildbot$ which svn > /usr/bin/svn > > I think that the git stub is always in /usr/bin currently, but I don't know > if that will never change. Looks like I have an svn in /usr/bin/svn too, even though which svn points to a different one.
Jonathan Bedard
Comment 6 2020-03-05 16:47:00 PST
Created attachment 392649 [details] Patch
Alexey Proskuryakov
Comment 7 2020-03-05 17:07:26 PST
Comment on attachment 392649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392649&action=review > Tools/Scripts/webkitpy/common/checkout/scm/svn.py:79 > + executable_name = '/usr/bin/svn' Pretty sure that /usr/bin/svn isn't guaranteed to exist either. Also, this code isn't about macOS only, or is it?
Note You need to log in before you can comment on or make changes to this bug.