Bug 208625 - Make m_viewportConstrainedObjects into a WeakHashSet
Summary: Make m_viewportConstrainedObjects into a WeakHashSet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-04 22:00 PST by Simon Fraser (smfr)
Modified: 2020-03-05 11:45 PST (History)
16 users (show)

See Also:

Attachments
Patch (10.51 KB, patch)
2020-03-04 22:00 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (10.88 KB, patch)
2020-03-05 09:08 PST, Simon Fraser (smfr) 		koivisto: review+
Details | Formatted Diff | Diff
Patch (11.48 KB, patch)
2020-03-05 09:19 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-03-04 22:00:16 PST 
Make m_viewportConstrainedObjects into a WeakHashSet
Comment 1 Simon Fraser (smfr) 2020-03-04 22:00:45 PST 
Created attachment 392535 [details]
Patch
Comment 2 Ryosuke Niwa 2020-03-04 22:05:27 PST 
Comment on attachment 392535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392535&action=review

> Source/WebCore/page/FrameView.h:301
> -    bool hasViewportConstrainedObjects() const { return m_viewportConstrainedObjects && m_viewportConstrainedObjects->size() > 0; }
> +    bool hasViewportConstrainedObjects() const { return m_viewportConstrainedObjects && m_viewportConstrainedObjects->computeSize(); }

Use !m_viewportConstrainedObjects->computeEmpty() instead. computeSize() will iterate over the entire map.
Comment 3 Simon Fraser (smfr) 2020-03-05 09:08:59 PST 
Created attachment 392580 [details]
Patch
Comment 4 Antti Koivisto 2020-03-05 09:11:38 PST 
Comment on attachment 392580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392580&action=review

> Source/WebCore/page/FrameView.h:299
> +    typedef WeakHashSet<RenderLayerModelObject> ViewportConstrainedObjectSet;

using ViewportConstrainedObjectSet = WeakHashSet<RenderLayerModelObject>;
reads better though I'm not sure this is needed in the first place.
Comment 5 Simon Fraser (smfr) 2020-03-05 09:19:04 PST 
Created attachment 392583 [details]
Patch
Comment 6 WebKit Commit Bot 2020-03-05 11:06:24 PST 
Comment on attachment 392583 [details]
Patch

Clearing flags on attachment: 392583

Committed r257933: <https://trac.webkit.org/changeset/257933>
Comment 7 Radar WebKit Bug Importer 2020-03-05 11:45:16 PST 
<rdar://problem/60093382>