Bug 208606 - [VNE layout] Move visually non-empty content reporting to RenderTreeBuilder
Summary: [VNE layout] Move visually non-empty content reporting to RenderTreeBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-04 14:36 PST by zalan
Modified: 2020-03-04 19:46 PST (History)
12 users (show)

See Also:

Attachments
Patch (10.96 KB, patch)
2020-03-04 14:42 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (11.06 KB, patch)
2020-03-04 16:23 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-03-04 14:36:29 PST 
from the renderer c'tors
Comment 1 Radar WebKit Bug Importer 2020-03-04 14:36:53 PST 
<rdar://problem/60056951>
Comment 2 zalan 2020-03-04 14:42:26 PST 
Created attachment 392487 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-03-04 14:46:40 PST 
Comment on attachment 392487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392487&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:925
> +        if (style.visibility() == Visibility::Visible && !style.fontCascade().isLoadingCustomFonts()) {

The isLoadingCustomFonts() seems wrong. It might be loading custom fonts but rendering with the fallback font, right? There's CSS to control this.

Also I guess we don't care about style.visibility() == Hidden on an ancestor?
Comment 4 zalan 2020-03-04 14:47:46 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 392487 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392487&action=review
> 
> > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:925
> > +        if (style.visibility() == Visibility::Visible && !style.fontCascade().isLoadingCustomFonts()) {
> 
> The isLoadingCustomFonts() seems wrong. It might be loading custom fonts but
> rendering with the fallback font, right? There's CSS to control this.
> 
> Also I guess we don't care about style.visibility() == Hidden on an ancestor?
Yeah. This is very basic.
Comment 5 zalan 2020-03-04 16:23:01 PST 
Created attachment 392503 [details]
Patch
Comment 6 WebKit Commit Bot 2020-03-04 19:46:26 PST 
Comment on attachment 392503 [details]
Patch

Clearing flags on attachment: 392503

Committed r257899: <https://trac.webkit.org/changeset/257899>
Comment 7 WebKit Commit Bot 2020-03-04 19:46:28 PST 
All reviewed patches have been landed.  Closing bug.