WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
208579
Remove PlatformPath, PlatformPathPtr, and PlatformPathStorageType typedefs in Path.h
https://bugs.webkit.org/show_bug.cgi?id=208579
Summary
Remove PlatformPath, PlatformPathPtr, and PlatformPathStorageType typedefs in...
Wenson Hsieh
Reported
2020-03-04 10:02:06 PST
These are essentially unused, don’t provide much tangible benefit since there’s no platform agnostic code that reasons with any of these “abstract” types.
Attachments
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2020-03-04 10:11:46 PST
From
https://bugs.webkit.org/show_bug.cgi?id=208492
: Darin Adler 2020-03-04 10:07:09 PST (In reply to Wenson Hsieh from
comment #12
)
> Would you suggest we rename platformPath, ensurePlatformPath, and m_path to > something along the lines of nativePath, ensureNativePath, and m_nativePath > (respectively)?
For CG, I would suggesting calling them something like this: pathCG or immutableCGPath or cgPath mutableCGPath m_path or m_pathCG or m_cgPath No abstract name for "what CG is", because the code that uses this will all be CG-specific.
Darin Adler
Comment 2
2020-03-04 19:54:34 PST
Other possible naming would be m_underlyingPath
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug