Bug 208561 - Move WKTextSelectionRect into its own file
Summary: Move WKTextSelectionRect into its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 13
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 208563
  Show dependency tree / graph
 
Reported: 2020-03-03 22:58 PST by Daniel Bates
Modified: 2020-03-04 10:05 PST (History)
2 users (show)

See Also:

Attachments
Patch (14.40 KB, patch)
2020-03-03 23:00 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (14.40 KB, patch)
2020-03-03 23:01 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (14.40 KB, patch)
2020-03-03 23:12 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-03-03 22:58:29 PST 
Move WKTextSelectionRect into its own file.
Comment 1 Daniel Bates 2020-03-03 23:00:55 PST 
Created attachment 392375 [details]
Patch
Comment 2 Daniel Bates 2020-03-03 23:01:44 PST 
Created attachment 392376 [details]
Patch
Comment 3 Daniel Bates 2020-03-03 23:12:02 PST 
Created attachment 392378 [details]
Patch
Comment 4 Alex Christensen 2020-03-04 08:47:49 PST 
Comment on attachment 392378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392378&action=review

> Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm:32
> +#import <WebKit/WebSelectionRect.h>

Do we still need this in WKContentViewInteraction.mm?
Comment 5 Daniel Bates 2020-03-04 09:54:16 PST 
(In reply to Alex Christensen from comment #4)
> Comment on attachment 392378 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392378&action=review
> 
> > Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm:32
> > +#import <WebKit/WebSelectionRect.h>
> 
> Do we still need this in WKContentViewInteraction.mm?

Yes for webSelectionRectsForSelectionRects(), but I sooo wanted to remove it. I was very tempted to move webSelectionRectsForSelectionRects() out of it to do so, but I decided to do a smaller step just to make it easy to a review.
Comment 6 Daniel Bates 2020-03-04 09:54:34 PST 
Thanks for the review.
Comment 7 Daniel Bates 2020-03-04 10:04:09 PST 
Comment on attachment 392378 [details]
Patch

Clearing flags on attachment: 392378

Committed r257851: <https://trac.webkit.org/changeset/257851>
Comment 8 Daniel Bates 2020-03-04 10:04:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-03-04 10:05:17 PST 
<rdar://problem/60044325>