Bug 208544 - commit-queue should run WK2 tests instead of WK1 tests
Summary: commit-queue should run WK2 tests instead of WK1 tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-03 16:01 PST by Aakash Jain
Modified: 2020-03-06 08:29 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.27 KB, patch)
2020-03-03 16:10 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-03-03 16:01:05 PST 
commit-queue should run WK2 tests instead of WK1 tests. 

As per https://bugs.webkit.org/show_bug.cgi?id=208521#c7: "there are now many WebKit2 only features and more code in WebKit2 itself. So I also think that we should switch CQ to WebKit2."
Comment 1 Aakash Jain 2020-03-03 16:10:43 PST 
Created attachment 392346 [details]
Patch
Comment 2 Jonathan Bedard 2020-03-04 07:40:57 PST 
I'd like Alexey to confirm the original rationale, which I suspect was that WebKit1 tests were more stable and better gardened.
Comment 3 Jonathan Bedard 2020-03-04 07:41:47 PST 
(In reply to Jonathan Bedard from comment #2)
> I'd like Alexey to confirm the original rationale, which I suspect was that
> WebKit1 tests were more stable and better gardened.

Didn't read through all my email:

"IIRC they were gardened equally well, but we knew that WebKit2 ran fewer tests because of unimplemented WebKitTestRunner functionality. 

That's still true as far as functionality goes, but there are now many WebKit2 only features and more code in WebKit2 itself. So I also think that we should switch CQ to WebKit2."
Comment 4 Alexey Proskuryakov 2020-03-04 09:54:02 PST 
Please do send a heads up to webkit-dev.
Comment 5 WebKit Commit Bot 2020-03-05 10:28:51 PST 
Committed r257927: <https://trac.webkit.org/changeset/257927>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 392346 [details].
Comment 6 Radar WebKit Bug Importer 2020-03-05 10:29:36 PST 
<rdar://problem/60089536>