Bug 208539 - [ews] Add build step to create local git commit for commit-queue
Summary: [ews] Add build step to create local git commit for commit-queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-03 14:44 PST by Aakash Jain
Modified: 2020-03-04 11:40 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.07 KB, patch)
2020-03-03 14:46 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Patch (9.01 KB, patch)
2020-03-04 08:02 PST, Aakash Jain 		jbedard: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-03-03 14:44:06 PST 
Add build step to create local git commit for commit-queue (in new EWS).
Comment 1 Aakash Jain 2020-03-03 14:46:58 PST 
Created attachment 392337 [details]
Patch
Comment 2 Aakash Jain 2020-03-03 14:47:59 PST 
Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/1059
Comment 3 Jonathan Bedard 2020-03-03 15:17:31 PST 
Comment on attachment 392337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392337&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:2474
> +        commit_message_filename = '/tmp/{}.txt'.format(self.getProperty('patch_id'))

Any reason we can't store the commit_message in a purporter and then use 'git commit --all --file -' and pip the commit message over stdin?

Seems cleaner than sending it into a file.
Comment 4 Aakash Jain 2020-03-04 08:02:30 PST 
Created attachment 392415 [details]
Patch
Comment 5 Aakash Jain 2020-03-04 08:03:28 PST 
(In reply to Jonathan Bedard from comment #3)
> Any reason we can't store the commit_message in a purporter and then use 'git commit --all --file -' and pipe the commit message over stdin?
Done in updated patch.
Comment 6 Jonathan Bedard 2020-03-04 09:10:00 PST 
Comment on attachment 392415 [details]
Patch

Much cleaner all in the same step!
Comment 7 Aakash Jain 2020-03-04 09:40:24 PST 
Committed r257848: <https://trac.webkit.org/changeset/257848>
Comment 8 Radar WebKit Bug Importer 2020-03-04 09:41:17 PST 
<rdar://problem/60043246>