Bug 208535 - [ews] Add build step to generate commit message
Summary: [ews] Add build step to generate commit message
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-03 13:48 PST by Aakash Jain
Modified: 2021-02-19 08:54 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.72 KB, patch)
2020-03-03 14:07 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-03-03 13:48:20 PST 
[ews] Add build step to find generate commit message for commit-queue.
Comment 1 Aakash Jain 2020-03-03 14:07:15 PST 
Created attachment 392326 [details]
Patch
Comment 2 Aakash Jain 2020-03-03 14:09:30 PST 
Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/1057
Comment 3 Jonathan Bedard 2020-03-03 15:15:36 PST 
Comment on attachment 392326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392326&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:2482
> +        self.command = 'perl Tools/Scripts/commit-log-editor --print-log {} > {}'.format(modified_changelogs, commit_message_filename)

It feels wrong to place the commit message in a temp file only to be used in the next step. Was this what the previous code did? How do we know that tmp won't be cleared out between this step and the next?

Any reason we can't stick this output in property to be used by the next step?
Comment 4 Aakash Jain 2020-03-04 09:41:20 PST 
Included this change in https://bugs.webkit.org/show_bug.cgi?id=208539