Bug 208496 - Deny darwin-notification-post
Summary: Deny darwin-notification-post
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-02 20:09 PST by Brent Fulgham
Modified: 2020-03-09 16:50 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.07 KB, patch)
2020-03-02 20:24 PST, Brent Fulgham 		pvollan: review+
bfulgham: commit-queue?
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-03-02 20:09:13 PST 
We don’t want WebContent to post any libnotify notifications, only register for them.
Comment 1 Brent Fulgham 2020-03-02 20:18:53 PST 
<rdar://problem/56948030>
Comment 2 Brent Fulgham 2020-03-02 20:24:43 PST 
Created attachment 392243 [details]
Patch
Comment 3 Per Arne Vollan 2020-03-03 10:51:38 PST 
Comment on attachment 392243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392243&action=review

R=me.

> Source/WebKit/ChangeLog:9
> +        We donât want WebContent to post any libnotify notifications, only register for them.

Should this be "don't"?
Comment 4 Per Arne Vollan 2020-03-03 10:52:10 PST 
I think the mac-wk2 test failures are unrelated.
Comment 5 Brent Fulgham 2020-03-03 21:23:50 PST 
This actually seems related:

CRASHING TEST: fast/events/onchange-passwordfield.html

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x0000000103bc5cf8 WebCore::postUserInfoForChanges(WebCore::AXCoreObject&, WebCore::AXCoreObject&, NSMutableArray*) + 184
1   com.apple.WebCore             	0x0000000103bc5a92 WebCore::AXObjectCache::postTextReplacementPlatformNotification(WebCore::AXCoreObject*, WebCore::AXTextEditType, WTF::String const&, WebCore::AXTextEditType, WTF::String const&, WebCore::VisiblePosition const&) + 226
2   com.apple.WebCore             	0x0000000103bc599a WebCore::AXObjectCache::postTextStateChangePlatformNotification(WebCore::AccessibilityObject*, WebCore::AXTextEditType, WTF::String const&, WebCore::VisiblePosition const&) + 74
3   com.apple.WebCore             	0x00000001045a9803 WebCore::AXObjectCache::passwordNotificationPostTimerFired() + 179
4   com.apple.WebCore             	0x0000000104e90e53 WebCore::ThreadTimers::sharedTimerFiredInternal() + 163
5   com.apple.WebCore             	0x0000000104eb679f WebCore::timerFired(__CFRunLoopTimer*, void*) + 31
6   com.apple.CoreFoundation      	0x00007fff2bbf25d5 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
7   com.apple.CoreFoundation      	0x00007fff2bbf2181 __CFRunLoopDoTimer + 864
8   com.apple.CoreFoundation      	0x00007fff2bbf1cba __CFRunLoopDoTimers + 330
9   com.apple.CoreFoundation      	0x00007fff2bbd3304 __CFRunLoopRun + 2141
10  com.apple.CoreFoundation      	0x00007fff2bbd2855 CFRunLoopRunSpecific + 459
11  com.apple.Foundation          	0x00007fff2de5532f -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 280
12  com.apple.Foundation          	0x00007fff2de55204 -[NSRunLoop(NSRunLoop) run] + 76
13  libxpc.dylib                  	0x00007fff57dfb077 _xpc_objc_main + 552
14  libxpc.dylib                  	0x00007fff57dfab79 xpc_main + 433
15  com.apple.WebKit              	0x0000000101fa4bb6 WebKit::XPCServiceMain(int, char const**) + 557
16  libdyld.dylib                 	0x00007fff57bc23d5 start + 1
Comment 6 Brent Fulgham 2020-03-09 16:50:05 PDT 
This is on hold while we resolve a system issue.