Bug 208458 - Web Inspector: Remove old raster icons for object types and resources
Summary: Web Inspector: Remove old raster icons for object types and resources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Jon Davis
URL:
Keywords: InRadar
Depends on:
Blocks: 209433 209434
  Show dependency tree / graph
 
Reported: 2020-03-02 11:22 PST by Jon Davis
Modified: 2020-03-23 12:32 PDT (History)
10 users (show)

See Also:

Attachments
Patch (302.87 KB, patch)
2020-03-02 11:26 PST, Jon Davis 		no flags Details | Formatted Diff | Diff
Patch (302.91 KB, patch)
2020-03-02 11:42 PST, Jon Davis 		no flags Details | Formatted Diff | Diff
Patch (302.85 KB, patch)
2020-03-03 10:23 PST, Jon Davis 		no flags Details | Formatted Diff | Diff
Patch (302.84 KB, patch)
2020-03-03 10:26 PST, Jon Davis 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2020-03-02 11:22:09 PST 
The old PNG files can be removed now that SVG alternatives are in place.
Comment 1 Jon Davis 2020-03-02 11:26:40 PST 
Created attachment 392164 [details]
Patch
Comment 2 Jon Davis 2020-03-02 11:42:19 PST 
Created attachment 392165 [details]
Patch
Comment 3 Devin Rousso 2020-03-02 18:01:57 PST 
Comment on attachment 392165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392165&action=review

r=me, but please wait till <https://webkit.org/b/208453> is landed as current ToT still uses some of these icons

> Source/WebInspectorUI/ChangeLog:83
> +        * UserInterface/Images/Function.svg: Removed.

This is still used by `WI.ThreadTreeElement`.

> Source/WebInspectorUI/ChangeLog:89
> +        * UserInterface/Images/HeapSnapshotSelected.svg: Removed.

This is still used by `WI.HeapAllocationsTimelineOverviewGraph`.

> Source/WebInspectorUI/ChangeLog:98
> +        * UserInterface/Images/NavigationItemNetworkOverride.svg:

This isn't in this patch.

> Source/WebInspectorUI/ChangeLog:117
> +        * UserInterface/Images/Thread.svg: Removed.

This is still used by `WI.ThreadTreeElement`.

> Source/WebInspectorUI/ChangeLog:137
> +        * UserInterface/Images/TypeObject.svg: Removed.

This is still used by `WI.SourcesNavigationSidebarPanel`.
Comment 4 Jon Davis 2020-03-03 10:23:10 PST 
Created attachment 392292 [details]
Patch
Comment 5 Jon Davis 2020-03-03 10:26:37 PST 
Created attachment 392294 [details]
Patch
Comment 6 WebKit Commit Bot 2020-03-03 11:41:53 PST 
Comment on attachment 392294 [details]
Patch

Clearing flags on attachment: 392294

Committed r257791: <https://trac.webkit.org/changeset/257791>
Comment 7 WebKit Commit Bot 2020-03-03 11:41:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-03-03 11:42:16 PST 
<rdar://problem/60005915>