Bug 208398 - Add new Mac target numbers
Summary: Add new Mac target numbers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alan Coon
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-28 16:19 PST by Alan Coon
Modified: 2020-03-02 18:51 PST (History)
20 users (show)

See Also:

Attachments
Patch (33.15 KB, patch)
2020-02-28 16:26 PST, Alan Coon 		no flags Details | Formatted Diff | Diff
Patch (51.72 KB, patch)
2020-03-02 15:13 PST, Alan Coon 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Coon 2020-02-28 16:19:00 PST 
Add new Mac target numbers.
Comment 1 Alan Coon 2020-02-28 16:26:25 PST 
Created attachment 392032 [details]
Patch
Comment 2 EWS Watchlist 2020-02-28 16:27:33 PST 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Alexey Proskuryakov 2020-02-28 18:17:13 PST 
Comment on attachment 392032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392032&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Add new Mac target numbers

You are only updating xcconfigs in Source. Please update all projects, including those in Tools.
Comment 4 Alexey Proskuryakov 2020-02-29 09:12:48 PST 
Please see r241990, r244714, r249312.
Comment 5 Alan Coon 2020-03-02 15:13:51 PST 
Created attachment 392199 [details]
Patch
Comment 6 Alexey Proskuryakov 2020-03-02 15:31:30 PST 
Comment on attachment 392199 [details]
Patch

With some spot checking, this seems to cover all that we did last year. Did you chek if we had any new projects added since then?
Comment 7 Alan Coon 2020-03-02 16:19:18 PST 
I checked with the following command, so we should be OK.

grep -r -l --include \*.xcconfig 'TARGET_MAC_OS_X\|WK_MACOS_1014_YES\|WK_MACOS_BEFORE\|SYSTEM_VERSION_PREFIX_macosx\|MACOS_DEPLOYMENT_TARGET_macosx' . | sort -u
Comment 8 WebKit Commit Bot 2020-03-02 18:50:01 PST 
Comment on attachment 392199 [details]
Patch

Clearing flags on attachment: 392199

Committed r257755: <https://trac.webkit.org/changeset/257755>
Comment 9 WebKit Commit Bot 2020-03-02 18:50:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-03-02 18:51:14 PST 
<rdar://problem/59978992>