Bug 208392 - Clean up code with how we choose Gigacage sizes and whether or not to use Wasm fast memory
Summary: Clean up code with how we choose Gigacage sizes and whether or not to use Was...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-28 14:02 PST by Saam Barati
Modified: 2020-02-28 16:00 PST (History)
13 users (show)

See Also:

Attachments
patch (3.24 KB, patch)
2020-02-28 14:05 PST, Saam Barati 		ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing (3.23 KB, patch)
2020-02-28 14:12 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-02-28 14:02:33 PST 
...
Comment 1 Saam Barati 2020-02-28 14:05:43 PST 
Created attachment 392018 [details]
patch
Comment 2 Yusuke Suzuki 2020-02-28 14:06:58 PST 
Comment on attachment 392018 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392018&action=review

r=me

> Source/JavaScriptCore/runtime/OptionsList.h:462
> +    v(Bool, useWebAssemblyFastMemory, WTF_OS_CONSTANT_EFFECTIVE_ADDRESS_WIDTH >= 48, Normal, "If true, we will try to use a 32-bit address space with a signal handler to bounds check wasm memory.") \

Use `OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH)` instead.
Comment 3 Saam Barati 2020-02-28 14:12:08 PST 
Created attachment 392019 [details]
patch for landing
Comment 4 WebKit Commit Bot 2020-02-28 15:59:31 PST 
Comment on attachment 392019 [details]
patch for landing

Clearing flags on attachment: 392019

Committed r257662: <https://trac.webkit.org/changeset/257662>
Comment 5 WebKit Commit Bot 2020-02-28 15:59:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-02-28 16:00:16 PST 
<rdar://problem/59907312>