Bug 208358 - Stop using -[CALayer setValue:forKey:] to store back pointers to PlatformCALayer*
Summary: Stop using -[CALayer setValue:forKey:] to store back pointers to PlatformCALa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-27 17:21 PST by Simon Fraser (smfr)
Modified: 2020-02-29 09:25 PST (History)
6 users (show)

See Also:

Attachments
Patch (12.53 KB, patch)
2020-02-27 17:25 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Patch (15.14 KB, patch)
2020-02-27 22:03 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (15.33 KB, patch)
2020-02-27 23:10 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (15.32 KB, patch)
2020-02-27 23:38 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (15.64 KB, patch)
2020-02-28 08:08 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-02-27 17:21:48 PST 
Stop using -[CALayer setValue:forKey:] to store back pointers to PlatformCALayer*
Comment 1 Simon Fraser (smfr) 2020-02-27 17:25:43 PST 
Created attachment 391945 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-02-27 22:03:59 PST 
Created attachment 391961 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-02-27 23:10:29 PST 
Created attachment 391964 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-02-27 23:38:04 PST 
Created attachment 391965 [details]
Patch
Comment 5 Simon Fraser (smfr) 2020-02-28 08:08:17 PST 
Created attachment 391981 [details]
Patch
Comment 6 Simon Fraser (smfr) 2020-02-28 11:24:04 PST 
https://trac.webkit.org/changeset/257645/webkit
Comment 7 Radar WebKit Bug Importer 2020-02-28 11:25:36 PST 
<rdar://problem/59895819>
Comment 8 Aakash Jain 2020-02-29 09:25:05 PST 
(In reply to Simon Fraser (smfr) from comment #6)
> https://trac.webkit.org/changeset/257645/webkit
This seems to have broken Windows build. Tracked in https://bugs.webkit.org/show_bug.cgi?id=208416

EWS also indicated this failure: https://ews-build.webkit.org/#/builders/10/builds/8585