Bug 208330 - [Win] Fix AppleWin build
Summary: [Win] Fix AppleWin build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-27 11:02 PST by Per Arne Vollan
Modified: 2020-02-27 15:45 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.34 KB, patch)
2020-02-27 11:49 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (1.31 KB, text/plain)
2020-02-27 14:36 PST, Per Arne Vollan 		no flags Details
Patch (1.98 KB, patch)
2020-02-27 14:41 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (2.08 KB, patch)
2020-02-27 14:45 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-02-27 11:02:36 PST 
CMake is giving an error:

Imported target "WebKit::WTF" includes non-existent path
.../Debug/build32/DerivedSources/ForwardingHeaders/
in its INTERFACE_INCLUDE_DIRECTORIES.
Comment 1 Radar WebKit Bug Importer 2020-02-27 11:07:56 PST 
<rdar://problem/59853955>
Comment 2 Per Arne Vollan 2020-02-27 11:49:26 PST 
Created attachment 391893 [details]
Patch
Comment 3 Don Olmstead 2020-02-27 11:55:58 PST 
Comment on attachment 391893 [details]
Patch

This is wrong. You should be setting this to where the headers actually are.

I'm guessing you should move the setting of these values into the target files. So like

set(WTF_FRAMEWORK_HEADERS_DIR "${CMAKE_BINARY_DIR}/../include/private/WTF")

Also https://bugs.webkit.org/show_bug.cgi?id=205085 still needs to land
Comment 4 Per Arne Vollan 2020-02-27 13:18:45 PST 
(In reply to Don Olmstead from comment #3)
> Comment on attachment 391893 [details]
> Patch
> 
> This is wrong. You should be setting this to where the headers actually are.
> 
> I'm guessing you should move the setting of these values into the target
> files. So like
> 
> set(WTF_FRAMEWORK_HEADERS_DIR "${CMAKE_BINARY_DIR}/../include/private/WTF")
> 

It doesn't seem like we used to set this for AppleWin, if I am not mistaken. Is it still needed?

Thanks for reviewing!
Comment 5 Per Arne Vollan 2020-02-27 14:36:52 PST 
Created attachment 391919 [details]
Patch
Comment 6 Per Arne Vollan 2020-02-27 14:41:11 PST 
Created attachment 391920 [details]
Patch
Comment 7 Per Arne Vollan 2020-02-27 14:45:57 PST 
Created attachment 391921 [details]
Patch
Comment 8 WebKit Commit Bot 2020-02-27 15:45:21 PST 
Comment on attachment 391921 [details]
Patch

Clearing flags on attachment: 391921

Committed r257595: <https://trac.webkit.org/changeset/257595>
Comment 9 WebKit Commit Bot 2020-02-27 15:45:23 PST 
All reviewed patches have been landed.  Closing bug.