Bug 208294 - REGRESSION(r257299): [GTK] Make focus ring of image area consistent with the theme
Summary: REGRESSION(r257299): [GTK] Make focus ring of image area consistent with the ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2020-02-27 03:01 PST by Carlos Garcia Campos
Modified: 2020-03-06 01:27 PST (History)
10 users (show)

See Also:

Attachments
Patch (3.33 KB, patch)
2020-02-27 03:05 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-02-27 03:01:50 PST 
Since r257299 the focus ring rendered by the theme has a different color and uses rounded corners. This is causing fast/images/image-map-outline-in-positioned-container.html to fail now, see

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r257556%20(12780)/fast/images/image-map-outline-in-positioned-container-diffs.html
Comment 1 Carlos Garcia Campos 2020-02-27 03:05:07 PST 
Created attachment 391846 [details]
Patch
Comment 2 Adrian Perez 2020-02-27 05:30:19 PST 
Comment on attachment 391846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391846&action=review

Patch LGTM but there is a typo that is breaking the other ports (see below).
That needs to be fixed before landing, hence the cq-.

> Source/WebCore/html/HTMLAreaElement.cpp:140
> +    return TWF::nullopt;

s/TWF/WTF
Comment 3 Carlos Garcia Campos 2020-03-06 01:27:15 PST 
I've realized that we were indeed honoring the outline color in css before in GTK. I'm not entirely happy with using rounded corners for image map outline only when using rectangle areas. So, I think we can just mark the test as image only failure for now.