Bug 208267 - MediaResourceLoader leaks resource responses
Summary: MediaResourceLoader leaks resource responses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-26 15:20 PST by Chris Dumez
Modified: 2020-02-28 13:24 PST (History)
11 users (show)

See Also:

Attachments
Patch (3.74 KB, patch)
2020-02-26 15:23 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-02-26 15:20:27 PST 
MediaResourceLoader leaks resource responses when browsing in Safari, even though these responses are only used for testing.
AVAssetCustomURLBridgeForNSURLSession holds on to the WebCoreNSURLSession, which keeps the MediaResourceLoader alive, even if there is no media on the current page. In turn, the MediaResourceLoader always keeps in memory the last 5 HTTP responses.
Comment 1 Chris Dumez 2020-02-26 15:23:14 PST 
Created attachment 391788 [details]
Patch
Comment 2 WebKit Commit Bot 2020-02-28 13:23:59 PST 
Comment on attachment 391788 [details]
Patch

Clearing flags on attachment: 391788

Committed r257655: <https://trac.webkit.org/changeset/257655>
Comment 3 WebKit Commit Bot 2020-02-28 13:24:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-02-28 13:24:15 PST 
<rdar://problem/59900095>